Use namespaced/weak features; MSRV 1.60 #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
use-namespaced-and-weak-features
branch
4 times, most recently
from
99919b8
to
ba54a9d
Compare
This was referenced Dec 13, 2022
Closed
tarcieri
force-pushed
the
use-namespaced-and-weak-features
branch
from
ba54a9d
to
58e0dcf
Compare
This enables activating the `alloc` and `std` features without unnecessarily pulling in optional dependencies like `rand` and `serde`. It also fixes tests for `--no-default-features` (w\ `--lib` only)
tarcieri
force-pushed
the
use-namespaced-and-weak-features
branch
from
58e0dcf
to
8f47fd5
Compare
|
LGTM. One thing I wanna do is go through all the |
|
@rozbb the main use is enabling the However, there is at least one legitimate use for https://docs.rs/pkcs8/latest/pkcs8/trait.EncodePrivateKey.html#method.write_pkcs8_der_file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables activating the
allocandstdfeatures without unnecessarily pulling in optional dependencies likerandandserde.It also fixes tests for
--no-default-features(w\--libonly)Closes #234 (I think?)