Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade cargo to use rand0.7 #91

Closed
wants to merge 1 commit into from
Closed

upgrade cargo to use rand0.7 #91

wants to merge 1 commit into from

Conversation

Silur
Copy link

@Silur Silur commented Jul 15, 2019

Didn't know whether this 1 byte requries a PR ot not (#89) :)

ps.: hope you are recovering well!

@tarcieri
Copy link
Contributor

See #90

@isislovecruft isislovecruft changed the base branch from master to develop October 7, 2019 20:34
@isislovecruft isislovecruft self-requested a review October 7, 2019 20:36
isislovecruft
isislovecruft requested changes Oct 7, 2019
View reviewed changes
Copy link
Member

@isislovecruft isislovecruft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't upgrade the rand crate until curve25519-dalek does, which would be a breaking API change, and thus won't happen until we release curve25519-dalek version 2.0.0.

@burdges
Copy link

burdges commented Oct 7, 2019

@Silur I've a commit that provides the required RngCore5As4 wrapper type at w3f/schnorrkel@8150ef6 which avoids rand 0.6 breaking no_std and being in your own public interface. See w3f/schnorrkel#31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isislovecruft isislovecruft isislovecruft requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Silur @tarcieri @burdges @isislovecruft