Initial Add Tags

Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
dalexandrov · Nov 17, 2023 · 0b831f8 · 0b831f8
1 parent 6da7534
commit 0b831f8
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 7 deletions.
diff --git a/tracing/opentracing/src/main/java/io/helidon/tracing/opentracing/OpenTracing.java b/tracing/opentracing/src/main/java/io/helidon/tracing/opentracing/OpenTracing.java
@@ -19,6 +19,8 @@
 
 import io.opentracing.Tracer;
 
+import java.util.Map;
+
 /**
  * Open Tracing factory methods to create wrappers for Open Tracing types.
  */
@@ -33,7 +35,7 @@ private OpenTracing() {
      * @return Helidon {@link io.helidon.tracing.Tracer}
      */
     public static io.helidon.tracing.Tracer create(Tracer tracer) {
-        return OpenTracingTracer.create(tracer);
+        return OpenTracingTracer.create(tracer, Map.of());
     }
 
     /**

diff --git a/tracing/opentracing/src/main/java/io/helidon/tracing/opentracing/OpenTracingTracer.java b/tracing/opentracing/src/main/java/io/helidon/tracing/opentracing/OpenTracingTracer.java
@@ -37,13 +37,17 @@ class OpenTracingTracer implements Tracer {
     private final io.opentracing.Tracer delegate;
     private final boolean enabled;
 
-    private OpenTracingTracer(io.opentracing.Tracer delegate, boolean enabled) {
+    private final Map<String, String> tags;
+
+
+    private OpenTracingTracer(io.opentracing.Tracer delegate, boolean enabled, Map<String, String> tags) {
         this.delegate = delegate;
         this.enabled = enabled;
+        this.tags = tags;
     }
 
-    static Tracer create(io.opentracing.Tracer tracer) {
-        return new OpenTracingTracer(tracer, !(tracer.scopeManager() instanceof NoopScopeManager));
+    static Tracer create(io.opentracing.Tracer tracer, Map<String, String> tags) {
+        return new OpenTracingTracer(tracer, !(tracer.scopeManager() instanceof NoopScopeManager), tags);
     }
 
     static Builder builder() {
@@ -57,7 +61,9 @@ public boolean enabled() {
 
     @Override
     public Span.Builder<?> spanBuilder(String name) {
-        return new OpenTracingSpanBuilder(delegate, delegate.buildSpan(name));
+        OpenTracingSpanBuilder builder = new OpenTracingSpanBuilder(delegate, delegate.buildSpan(name));
+        tags.forEach(builder::tag);
+        return builder;
     }
 
     @Override
@@ -122,7 +128,7 @@ private Builder() {
 
         @Override
         public Tracer build() {
-            return new OpenTracingTracer(delegate.build(), delegate.enabled());
+            return new OpenTracingTracer(delegate.build(), delegate.enabled(), Map.of());
         }
 
         @Override

diff --git a/...g/opentracing/src/main/java/io/helidon/tracing/opentracing/OpenTracingTracerProvider.java b/...g/opentracing/src/main/java/io/helidon/tracing/opentracing/OpenTracingTracerProvider.java
@@ -15,6 +15,7 @@
  */
 package io.helidon.tracing.opentracing;
 
+import java.util.Map;
 import java.util.Optional;
 
 import io.helidon.common.Prioritized;
@@ -40,7 +41,7 @@ public TracerBuilder<?> createBuilder() {
 
     @Override
     public Tracer global() {
-        return OpenTracingTracer.create(GlobalTracer.get());
+        return OpenTracingTracer.create(GlobalTracer.get(), Map.of());
     }
 
     @Override