add metrics to SE quickstarts (helidon-io#7114)

Signed-off-by: tvallin <thibault.vallin@oracle.com>
dalexandrov · Jun 27, 2023 · 8c5aff0 · 8c5aff0
1 parent a9dabfb
commit 8c5aff0
Show file tree

Hide file tree

Showing 5 changed files with 46 additions and 2 deletions.
diff --git a/archetypes/helidon/src/main/archetype/nima/quickstart/quickstart-nima.xml b/archetypes/helidon/src/main/archetype/nima/quickstart/quickstart-nima.xml
@@ -64,6 +64,14 @@ curl -X GET http://localhost:8080/greet/Jose
                     <value key="groupId">jakarta.json</value>
                     <value key="artifactId">jakarta.json-api</value>
                 </map>
+                <map order="999">
+                    <value key="groupId">io.helidon.nima.observe</value>
+                    <value key="artifactId">helidon-nima-observe-metrics</value>
+                </map>
+                <map order="999">
+                    <value key="groupId">io.helidon.metrics</value>
+                    <value key="artifactId">helidon-metrics</value>
+                </map>
             </list>
             <list key="Main-helidon-imports">
                 <value>io.helidon.health.checks.DeadlockHealthCheck</value>
@@ -76,7 +84,7 @@ curl -X GET http://localhost:8080/greet/Jose
             <list key="Main-routing">
                 <value><![CDATA[
         ObserveFeature observe = ObserveFeature.builder()
-                .useSystemServices(false)
+                .useSystemServices(true)
                 .addProvider(HealthObserveProvider.create(HealthFeature.builder()
                                                                   .useSystemServices(false)
                                                                   .addCheck(HeapMemoryHealthCheck.create())
@@ -121,6 +129,13 @@ curl -X GET http://localhost:8080/greet/Jose
             assertThat(response.status(), is(Http.Status.NO_CONTENT_204));
         }
     }
+
+    @Test
+    void testMetricsObserver() {
+        try (Http1ClientResponse response = client.get("/observe/metrics").request()) {
+            assertThat(response.status(), is(Http.Status.OK_200));
+        }
+    }
 ]]></value>
             </list>
         </model>

diff --git a/examples/quickstarts/helidon-quickstart-se/pom.xml b/examples/quickstarts/helidon-quickstart-se/pom.xml
@@ -49,6 +49,14 @@
             <groupId>io.helidon.nima.observe</groupId>
             <artifactId>helidon-nima-observe-health</artifactId>
         </dependency>
+        <dependency>
+            <groupId>io.helidon.nima.observe</groupId>
+            <artifactId>helidon-nima-observe-metrics</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>io.helidon.metrics</groupId>
+            <artifactId>helidon-metrics</artifactId>
+        </dependency>
         <dependency>
             <groupId>io.helidon.nima.openapi</groupId>
             <artifactId>helidon-nima-openapi</artifactId>

diff --git a/...tarts/helidon-quickstart-se/src/test/java/io/helidon/examples/quickstart/se/MainTest.java b/...tarts/helidon-quickstart-se/src/test/java/io/helidon/examples/quickstart/se/MainTest.java
@@ -65,4 +65,11 @@ void testDeadlockHealthCheck() {
             assertThat(response.status(), is(Http.Status.NO_CONTENT_204));
         }
     }
+
+    @Test
+    void testMetricsObserver() {
+        try (Http1ClientResponse response = client.get("/observe/metrics").request()) {
+            assertThat(response.status(), is(Http.Status.OK_200));
+        }
+    }
 }
diff --git a/examples/quickstarts/helidon-standalone-quickstart-se/pom.xml b/examples/quickstarts/helidon-standalone-quickstart-se/pom.xml
@@ -75,6 +75,14 @@
             <groupId>io.helidon.nima.observe</groupId>
             <artifactId>helidon-nima-observe-health</artifactId>
         </dependency>
+        <dependency>
+            <groupId>io.helidon.nima.observe</groupId>
+            <artifactId>helidon-nima-observe-metrics</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>io.helidon.metrics</groupId>
+            <artifactId>helidon-metrics</artifactId>
+        </dependency>
         <dependency>
             <groupId>io.helidon.config</groupId>
             <artifactId>helidon-config-yaml</artifactId>

diff --git a/...on-standalone-quickstart-se/src/test/java/io/helidon/examples/quickstart/se/MainTest.java b/...on-standalone-quickstart-se/src/test/java/io/helidon/examples/quickstart/se/MainTest.java
@@ -57,11 +57,17 @@ void testHealthObserver() {
             assertThat(response.status(), is(Http.Status.NO_CONTENT_204));
         }
     }
-
     @Test
     void testDeadlockHealthCheck() {
         try (Http1ClientResponse response = client.get("/observe/health/live/deadlock").request()) {
             assertThat(response.status(), is(Http.Status.NO_CONTENT_204));
         }
     }
+
+    @Test
+    void testMetricsObserver() {
+        try (Http1ClientResponse response = client.get("/observe/metrics").request()) {
+            assertThat(response.status(), is(Http.Status.OK_200));
+        }
+    }
 }