Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPPMiddleware: Support for Remote Start and Stop #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danielnord
Copy link
Contributor

Add support for:

  • RemoteStartTransaction
  • RemoteStopTransaction

Add support for:
* RemoteStartTransaction
* RemoteStopTransaction
@axen2u
Copy link

axen2u commented Jun 20, 2022

Hi, @danielnord Thanks for the implementation. How can I trigger the RemoteStartTransaction / RemoteStopTransaction from Central System?

@ximki
Copy link

ximki commented Jun 25, 2023

@danielnord You haven't handle the RemoteStartTransaction and RemoteStopTransaction, and you don't get any result back from them even they work actually but this line here
string apiResult = await msgOut.TaskCompletionSource.Task; will wait forever because it never completes,
I tried a solution on my own, however things get messy as the msgOut can't be passed from a HandlerMethod to another as they get reinitialized and completing the task on RemoteStartTransactionHandler wasn't a good idea as the StartTransaction command starts afterward and the result should be returned from the HandleStartTransaction method which returns the TransactionId :).
I am still trying to figure out how to make it work, I will leave a reply in case I make it :)

@pbonato
Copy link

pbonato commented Apr 28, 2024

Any news regarding the implementation of RemoteStartTransaction and RemoteStopTransaction ?

@ximki
Copy link

ximki commented Apr 28, 2024

Any news regarding the implementation of RemoteStartTransaction and RemoteStopTransaction ?

I did an ugly solution for myself, forgot the details but I remember I created a "tracker" class to know when to end the await of task completion, it worked when I tested it but as I said I don't remember details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants