-
-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header and footer overlapped by slide content #610
Comments
Hi IIUC you would expect the scrollable area to take the amount of space between the footer and header it seems easy to make this customizable somehow; I'll try to implement this in the not-too-distant future |
when scroll is selected, no longer hard-wire a height for the scroll area instead, set a class on those elements, that are default-styled in main.less but can be easily overridden by users in their CSS
I will publish this as a pip-installable version |
Hi, you may give this a try if you do this
which should give you release 5.7.2.dev0 and with that version in place, you will have the ability to set the height of the scroll area:
Here I say I want to keep 100px for the header, and that the scroll-area is to take 85% of the viewport height please let me know if that suits your needs |
Thanks for the quick fix! It seems to work very well now for slides with cells that are too long and scrolling is activated. However, if a slide is okay length-wise and scolling is not activated, the margin from section.rise-scroll doesn't work. If I put a margin to #notebook-container, the margin is doubled for slides with the scroll activated.
Also If I only activate the #notebook-container margin, the calculation of the height doesn't seem to work and the scroll is not activated correctly Is this easy to fix with just CSS and I just miss something? |
you meant height-wise here, right ? indeed there was a provision in the code here and so my patch adds the 'rise-scroll' class only on those would it be possible for you to share the slides (or a representative selection thereof) if they're not sensitive ? this way we could be sure to nail it down.. @damianavila |
all this being said, clearly the way we implemented the header-footer business in the first place could very fruitfully be revised by using a |
I tweaked the example notebook so that the issues are reproduced. I commited my changes just now to the issue610 branch. If pulled as is, you can see that the header is overlapping. For my case now, if the
Yea, that would be a pretty neat option in the future! |
hi |
hi, sorry I'm not too familiar with a public git yet so I don't really understand how I am able to push since I do not have permissions obviously. |
…he rise-scroll class on present section, regardless of its height the way we computed the height threshhold (based on a hard-wired .95 ratio) was very questionable in the first place this version seems to behave better on the 3 'header-footer' examples at least, i.e. with or without scroll, and in the scroll+center case as well
Hi |
I was trying to create a presentation with a header and footer. However, the header and footer are apparently not recognized as content of the slide, which results in the content either overlapping with the header or footer. Here is my CSS and HTML code I input to the overlay option.
So far I've managed to add a margin on top which solves the overlapping with the header. For the footer on the other hand I couldn't find the right element to change. I added the scroll option, but the content is still stretching to the bottom of the slide, overlapping with the footer.
I tried looking for the right container to change in my css file but nothing worked. Is there a way to add margin to the bottom as well or set the height of the content of the slide so that there is no overlapping anymore, but I can still scroll normally?
Any help is appreciated!
Thank you
Nikita
The text was updated successfully, but these errors were encountered: