Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data-completed #26

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Fix data-completed #26

merged 2 commits into from
Aug 19, 2024

Conversation

none23
Copy link
Contributor

@none23 none23 commented Aug 17, 2024

data-completed should probably depend on the step index, not on its id

`data-completed` should probably depend on the step index, not on its `id`
Copy link

changeset-bot bot commented Aug 17, 2024

🦋 Changeset detected

Latest commit: bf9694c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@stepperize/react Patch
docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stepperize ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 3:09am

@damianricobelli
Copy link
Owner

Good catch! Thanks

@damianricobelli damianricobelli self-requested a review August 19, 2024 03:10
@damianricobelli damianricobelli merged commit 546d510 into damianricobelli:main Aug 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants