feat(Next > TypeScript): Add TypeScript with strict enabled #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Conflicts: # next/package-lock.json # next/package.json
…as duplicate UI components of MUI
danactive
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TypeScript is enabled with Next.js though not all files are converts some stay as JSX which is okay for this PR as there are issues to resolve before merging.
There are two major errors based on my JavaScript migration to TypeScript:
The GeneralList and List are passing a React component around, but I don't know how to set the type properly- Replaced with MUI and deleted componentsTest plan
Runtsccurrently reports "Found 4 errors in 3 files."Runnpm run lintand some of the TypeScript types are breaking JS Lint rulesRunnpm run testand GenericList/tests/index.test.jsx has one test breakingRumnpm run buildwhich currently fails due to lint errors