Use libc::off_t instead of std::*::off_t #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modules in `std` may be slated for change, and in general it's best to keep the libc apis using libc types to guarantee they match up.
|
Thanks! I'll be looking into this this weekend. I doubt the test failures are your doing. |
danburkert
added a commit
that referenced
this pull request
Feb 6, 2016
Use libc::off_t instead of std::*::off_t
|
@danburkert could a new release be made with this change as well? The |
|
Just publish |
|
No worries, and thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modules in
stdmay be slated for change, and in general it's best to keep the libc apis using libc types to guarantee they match up.