make iter_from and iter_dup_from behave consistently w/nonexistent keys #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It previously called unwrap() which panics if a key isn't found
|
Merged as part of #37 |
ncloudioj
pushed a commit
to ncloudioj/lmdb-rs
that referenced
this pull request
Mar 13, 2019
use the mdb.RE/0.9-moz branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #29 (from which this branches), this makes iter_from and iter_dup_from behave consistently when seeking to a key that may or may not exist and may or may not be greater than any key in the store, which is more usable for callers whose behavior doesn't depend on the presence of the given key (nor any greater ones).