return error result from fallible iteration methods #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykmelez
force-pushed
the
return-error-result
branch
from
52c2ad3
to
99f24f7
Compare
This was referenced Oct 22, 2018
|
Closing this in favor of the approach in #48. |
stuhood
pushed a commit
to pantsbuild/lmdb-rs
that referenced
this pull request
Jan 25, 2022
….8.3 update patch version for lmdb-rkv-sys 0.8.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch implements the suggestion in #42 by returning an error result from fallible iteration methods (
Cursor.iter*()andIterator.next()) when those methods fail. See that issue for more info about the changes.