Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LMDB docs for mdb_env_set_mapsize says that the default map size is 10,485,760 bytes, i.e. 10MiB. But the
DEFAULT_MAPSIZE
define in the LMDB code sets the default map size to 1,048,576 bytes, i.e. 1MiB.I submitted a patch to fix the LMDB docs in issue 8322. That issue has been open for several years, and it isn't clear whether it's the docs or the
DEFAULT_MAPSIZE
define that is incorrect. But I suspect the former, since the comment aboveDEFAULT_MAPSIZE
says it's "certainly too small for any actual applications," which suggests that the smaller size was intentional.In any case, it's worth fixing the lmdb-rs docs to specify the correct value (even if the LMDB docs specify an incorrect one).