Have iter_from/iter_dup_from return a Result #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I don't have a local devenv set up for this, so apologies if the tests don't pass |
tarcieri
force-pushed
the
iter-from-result
branch
2 times, most recently
from
c1e8554
to
53bd225
Compare
It previously called unwrap() which panics if a key isn't found
tarcieri
force-pushed
the
iter-from-result
branch
from
53bd225
to
a520010
Compare
|
Well, the tests pass now, but it could probably use a new test to ensure |
tarcieri
force-pushed
the
iter-from-result
branch
2 times, most recently
from
c9c08c8
to
8799b2c
Compare
tarcieri
force-pushed
the
iter-from-result
branch
from
8799b2c
to
53fd6af
Compare
|
CC #13. Forgot this PR existed when I re-filed that issue. |
Merged
|
Merged as part of #37 |
ncloudioj
pushed a commit
to ncloudioj/lmdb-rs
that referenced
this pull request
Mar 13, 2019
prepare to publish on crates.io as lmdb-rkv package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It previously called unwrap() which panics if a key isn't found