Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Fork library #28

Conversation

marioevz
Copy link
Collaborator

Removed the mapping stuff, SOLC_VERSION_TO_SUPPORTED_FORKS and SOLC_FORKS_0_8_20, in favor of a fork class method called solc_min_version.

Also modified solc_name to do a .lower() before returning, I think this should fix the issue where the name is incorrect but let me know if it doesn't accomplish what you needed 👍

Copy link
Owner

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mario, much cleaner!

@danceratopz danceratopz merged commit 4ab1a93 into danceratopz:fix/pytest/fix-yul_test_marker__improve_compile_yul_with_marker Jan 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants