Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to find "github" theme / default theme has poor color contrast on default macOS terminal #1072

Closed
toolness opened this issue May 9, 2022 · 1 comment

Comments

@toolness
Copy link
Contributor

toolness commented May 9, 2022

Hello!

Your README mentions a "github" theme with a link to this screenshot:

https://user-images.githubusercontent.com/52205/81058911-6abcf700-8e9d-11ea-93be-e212824ec03d.png

However, I have been searching for about 10 minutes and cannot seem to find a way to activate this theme. The themes.gitconfig lists no theme called "github" and I can't find reference to it anywhere else in the documentation.

This is unfortunate since the default theme appears to be made for dark terminals, and the result (on my default MacOS terminal) has very poor contrast and color accessibility which makes it more difficult to read than regular git diff.

@dandavison
Copy link
Owner

Hi @toolness, use syntax-theme = GitHub to select the GitHub syntax-highlighting theme. (You can also specify light = true and GitHub will be selected as the default syntax-highlighting theme for light terminal backgrounds). You can use delta --list-syntax-themes and delta --show-syntax-themes to view the syntax highlighting themes. In general, delta --help is the point-of-truth documentation for all available delta configuration.

There's a distinction between "theme" and "syntax-highlighting theme", which is described here: https://dandavison.github.io/delta/custom-themes.html Basically a "theme" is a broader concept; one thing you can specify in a "theme" is the "syntax-highlighting theme".

toolness added a commit to toolness/delta that referenced this issue May 9, 2022
As mentioned in dandavison#1072, the macOS default terminal is light and it's challenging to find documentation on how to make delta copacetic with it, so this adds an explicit `light = false` in the `.gitconfig` example, with a comment explaining that it can be changed for light terminals.
dandavison pushed a commit that referenced this issue May 9, 2022
* Add 'light = false' w/ comment in gitconfig

As mentioned in #1072, the macOS default terminal is light and it's challenging to find documentation on how to make delta copacetic with it, so this adds an explicit `light = false` in the `.gitconfig` example, with a comment explaining that it can be changed for light terminals.

* Update README.md

fix indentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants