Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: release apple arm binary #1239

Merged
merged 8 commits into from
Dec 3, 2022
Merged

Conversation

MarcoIeni
Copy link
Contributor

@MarcoIeni MarcoIeni commented Nov 16, 2022

Requested here

There are no VMs for GitHub actions that support Mac ARM. See actions/runner-images#2187.
So we cannot run tests for MAC ARM. However, we can run cargo build, which is what's required to build the binary.

@MarcoIeni
Copy link
Contributor Author

Caused by:
  Bad CPU type in executable (os error 86)

I need to fix this.


steps:
- name: Installing Rust toolchain
uses: actions-rs/toolchain@v1
with:
toolchain: stable
target: ${{ matrix.job.target }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This installs the target if missing. Useful for aarch64-apple-darwin on mac

@MarcoIeni
Copy link
Contributor Author

This is ready now. 👍

@dandavison
Copy link
Owner

Hi @MarcoIeni, thanks for this work!

So basically, we add aarch64-apple-darwin to cd but not to ci. Is that an accurate summary?

I've merged your reformatting PR so I'll wait for you to rebase this one.

@MarcoIeni MarcoIeni marked this pull request as ready for review November 27, 2022 18:04
@MarcoIeni
Copy link
Contributor Author

So basically, we add aarch64-apple-darwin to cd but not to ci. Is that an accurate summary?

Yes, exactly

@dandavison dandavison merged commit 667d44c into dandavison:master Dec 3, 2022
@dandavison
Copy link
Owner

Thank you very much @MarcoIeni!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants