Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bytelines to latest, without default features #1597

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

whitfin
Copy link
Contributor

@whitfin whitfin commented Jan 5, 2024

Hi there! I found this project via an issue opened here: whitfin/bytelines#7 (totally a mistake on my part).

I've finally resolved this temporarily, by adding a feature for Tokio. It's still enabled by default to avoid a breaking change, but this means that you can now disable default features to exclude Tokio + relevant dependencies. Figured I'd file it here so you no longer have to specifically pin a version going forward.

At some point (time permitting) there will be a bytelines v3 which does this more correctly, but for now it'll be one less thing to think about on your end! I'm not sure if you want the Cargo.lock changes committed, but I can drop those out as necessary.

Thank you!

@dandavison dandavison merged commit 1db3aaa into dandavison:main Mar 2, 2024
11 of 12 checks passed
@dandavison
Copy link
Owner

Thanks @whitfin and thanks for bytelines!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants