Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic when blame-palette is empty #1737

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Fix panic when blame-palette is empty #1737

merged 3 commits into from
Jul 8, 2024

Conversation

thorio
Copy link
Contributor

@thorio thorio commented Jul 4, 2024

Currently, when blame-palette is set to an empty string, the application panics:

$ git blame ARCHITECTURE.md | delta --blame-palette ""
thread 'main' panicked at src/handlers/blame.rs:175:47:
attempt to calculate the remainder with a divisor of zero
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This patch replaces this with a nicer error message:

$ git blame ARCHITECTURE.md | delta --blame-palette ""
Option 'blame-palette' must not be empty.


if n_colors == 0 {
fatal("Option 'blame-palette' must not be empty.")
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thorio! I'm thinking that this should go earlier since it is essentially user input validation. Perhaps in src/config.rs where we first parse the argument. (Or maybe clap has a "value parsing" feature that we can use?)

Copy link
Contributor Author

@thorio thorio Jul 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that, but since the actual color is only parsed after this point, I just stuck the check here for simplicity.

Ideally clap would parse the color and palette, then store it in a struct or enum guaranteeing its validity, but that would be a larger change.

As for just moving it earlier in the execution, I think right after this line would be a good spot.

src/handlers/blame.rs Outdated Show resolved Hide resolved
@dandavison dandavison merged commit 716fa79 into dandavison:main Jul 8, 2024
13 checks passed
@dandavison
Copy link
Owner

Thanks!

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Aug 20, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [dandavison/delta](https://github.com/dandavison/delta) | minor | `0.17.0` -> `0.18.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>dandavison/delta (dandavison/delta)</summary>

### [`v0.18.0`](https://github.com/dandavison/delta/releases/tag/0.18.0)

[Compare Source](dandavison/delta@0.17.0...0.18.0)

As usual, tons of excellent contributions, all but one not by me! [@&#8203;th1000s](https://github.com/th1000s) has made a huge number of important and difficult improvements to delta and helped with many issues over the few years since the project started, and so I'm happy to say that he's co-maintaining the project with me nowadays. Thanks to all contributors for the improvements below!

#### What's Changed

-   Link to Repository from Manual by [@&#8203;bash](https://github.com/bash) in dandavison/delta#1657
-   Stop highlighting unchanged whitespace by [@&#8203;phillipwood](https://github.com/phillipwood) in dandavison/delta#1659
-   Add .gitattributes rules for rust files by [@&#8203;phillipwood](https://github.com/phillipwood) in dandavison/delta#1245
-   Repair --default-language, and highlight using full filename by [@&#8203;th1000s](https://github.com/th1000s) in dandavison/delta#1549
-   tests: prevent parallel env var access by [@&#8203;th1000s](https://github.com/th1000s) in dandavison/delta#1681
-   CI: fix macOS build by [@&#8203;th1000s](https://github.com/th1000s) in dandavison/delta#1696
-   Only use `nosort` in bash <4.4 by [@&#8203;martinml](https://github.com/martinml) in dandavison/delta#1683
-   Don't read git files when --no-gitconfig is given + unused variables by [@&#8203;th1000s](https://github.com/th1000s) in dandavison/delta#1728
-   tests: add insta for snapshot testing by [@&#8203;th1000s](https://github.com/th1000s) in dandavison/delta#1739
-   tests: set terminal width to 43 by [@&#8203;th1000s](https://github.com/th1000s) in dandavison/delta#1741
-   Fix panic when blame-palette is empty by [@&#8203;thorio](https://github.com/thorio) in dandavison/delta#1737
-   Make relative-paths work with binary files by [@&#8203;th1000s](https://github.com/th1000s) in dandavison/delta#1740
-   Fix github links from master to main by [@&#8203;madeddie](https://github.com/madeddie) in dandavison/delta#1709
-   Update `terminal-colorsaurus` by [@&#8203;bash](https://github.com/bash) in dandavison/delta#1699
-   Make less version >= 633 behave like previous versions wrt. Nerd Fonts by [@&#8203;th1000s](https://github.com/th1000s) in dandavison/delta#1762
-   Update `catppuccin-latte` casing in `LIGHT_SYNTAX_THEMES` list by [@&#8203;injust](https://github.com/injust) in dandavison/delta#1745
-   deps: bump libc from 0.2.153 to 0.2.155 by [@&#8203;wxpppp](https://github.com/wxpppp) in dandavison/delta#1715
-   Add missing `--file-*-label` option to `--navigate` docs by [@&#8203;injust](https://github.com/injust) in dandavison/delta#1744
-   Fix copy-paste typo by [@&#8203;injust](https://github.com/injust) in dandavison/delta#1767
-   Update syntect to 5.2.0 by [@&#8203;timhillgit](https://github.com/timhillgit) in dandavison/delta#1672
-   Disable light mode detection in tests by [@&#8203;bash](https://github.com/bash) in dandavison/delta#1765
-   Add --max-syntax-highlighting-length, set to 400 by [@&#8203;th1000s](https://github.com/th1000s) in dandavison/delta#1746
-   chore: cleanup brew formula file in favor of core tap by [@&#8203;chenrui333](https://github.com/chenrui333) in dandavison/delta#1773
-   wrap --help output, fix rust 1.80 build by [@&#8203;th1000s](https://github.com/th1000s) in dandavison/delta#1440
-   Fix delta-toggle shell script by [@&#8203;dandavison](https://github.com/dandavison) in dandavison/delta#1794
-   Do not wrap short help (-h) output by [@&#8203;th1000s](https://github.com/th1000s) in dandavison/delta#1800
-   Implement --diff-args by [@&#8203;dandavison](https://github.com/dandavison) in dandavison/delta#1697
-   Handle ambiguous diff header, '--- ' can also be present in a minus hunk by [@&#8203;th1000s](https://github.com/th1000s) in dandavison/delta#1787
-   cd: build binaries targeting GNU libc on ubuntu-20.04, not latest by [@&#8203;th1000s](https://github.com/th1000s) in dandavison/delta#1805

#### New Contributors

-   [@&#8203;martinml](https://github.com/martinml) made their first contribution in dandavison/delta#1683
-   [@&#8203;thorio](https://github.com/thorio) made their first contribution in dandavison/delta#1737
-   [@&#8203;madeddie](https://github.com/madeddie) made their first contribution in dandavison/delta#1709
-   [@&#8203;injust](https://github.com/injust) made their first contribution in dandavison/delta#1745
-   [@&#8203;wxpppp](https://github.com/wxpppp) made their first contribution in dandavison/delta#1715
-   [@&#8203;timhillgit](https://github.com/timhillgit) made their first contribution in dandavison/delta#1672
-   [@&#8203;chenrui333](https://github.com/chenrui333) made their first contribution in dandavison/delta#1773

**Full Changelog**: dandavison/delta@0.17.0...0.18.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
renovate bot referenced this pull request in d-issy/dotfiles Aug 23, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [dandavison/delta](https://togithub.com/dandavison/delta) | minor |
`0.17.0` -> `0.18.0` |

---

### Release Notes

<details>
<summary>dandavison/delta (dandavison/delta)</summary>

###
[`v0.18.0`](https://togithub.com/dandavison/delta/releases/tag/0.18.0)

[Compare
Source](https://togithub.com/dandavison/delta/compare/0.17.0...0.18.0)

As usual, tons of excellent contributions, all but one not by me!
[@&#8203;th1000s](https://togithub.com/th1000s) has made a huge number
of important and difficult improvements to delta and helped with many
issues over the few years since the project started, and so I'm happy to
say that he's co-maintaining the project with me nowadays. Thanks to all
contributors for the improvements below!

#### What's Changed

- Link to Repository from Manual by
[@&#8203;bash](https://togithub.com/bash) in
[https://github.com/dandavison/delta/pull/1657](https://togithub.com/dandavison/delta/pull/1657)
- Stop highlighting unchanged whitespace by
[@&#8203;phillipwood](https://togithub.com/phillipwood) in
[https://github.com/dandavison/delta/pull/1659](https://togithub.com/dandavison/delta/pull/1659)
- Add .gitattributes rules for rust files by
[@&#8203;phillipwood](https://togithub.com/phillipwood) in
[https://github.com/dandavison/delta/pull/1245](https://togithub.com/dandavison/delta/pull/1245)
- Repair --default-language, and highlight using full filename by
[@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1549](https://togithub.com/dandavison/delta/pull/1549)
- tests: prevent parallel env var access by
[@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1681](https://togithub.com/dandavison/delta/pull/1681)
- CI: fix macOS build by [@&#8203;th1000s](https://togithub.com/th1000s)
in
[https://github.com/dandavison/delta/pull/1696](https://togithub.com/dandavison/delta/pull/1696)
- Only use `nosort` in bash <4.4 by
[@&#8203;martinml](https://togithub.com/martinml) in
[https://github.com/dandavison/delta/pull/1683](https://togithub.com/dandavison/delta/pull/1683)
- Don't read git files when --no-gitconfig is given + unused variables
by [@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1728](https://togithub.com/dandavison/delta/pull/1728)
- tests: add insta for snapshot testing by
[@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1739](https://togithub.com/dandavison/delta/pull/1739)
- tests: set terminal width to 43 by
[@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1741](https://togithub.com/dandavison/delta/pull/1741)
- Fix panic when blame-palette is empty by
[@&#8203;thorio](https://togithub.com/thorio) in
[https://github.com/dandavison/delta/pull/1737](https://togithub.com/dandavison/delta/pull/1737)
- Make relative-paths work with binary files by
[@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1740](https://togithub.com/dandavison/delta/pull/1740)
- Fix github links from master to main by
[@&#8203;madeddie](https://togithub.com/madeddie) in
[https://github.com/dandavison/delta/pull/1709](https://togithub.com/dandavison/delta/pull/1709)
- Update `terminal-colorsaurus` by
[@&#8203;bash](https://togithub.com/bash) in
[https://github.com/dandavison/delta/pull/1699](https://togithub.com/dandavison/delta/pull/1699)
- Make less version >= 633 behave like previous versions wrt. Nerd Fonts
by [@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1762](https://togithub.com/dandavison/delta/pull/1762)
- Update `catppuccin-latte` casing in `LIGHT_SYNTAX_THEMES` list by
[@&#8203;injust](https://togithub.com/injust) in
[https://github.com/dandavison/delta/pull/1745](https://togithub.com/dandavison/delta/pull/1745)
- deps: bump libc from 0.2.153 to 0.2.155 by
[@&#8203;wxpppp](https://togithub.com/wxpppp) in
[https://github.com/dandavison/delta/pull/1715](https://togithub.com/dandavison/delta/pull/1715)
- Add missing `--file-*-label` option to `--navigate` docs by
[@&#8203;injust](https://togithub.com/injust) in
[https://github.com/dandavison/delta/pull/1744](https://togithub.com/dandavison/delta/pull/1744)
- Fix copy-paste typo by [@&#8203;injust](https://togithub.com/injust)
in
[https://github.com/dandavison/delta/pull/1767](https://togithub.com/dandavison/delta/pull/1767)
- Update syntect to 5.2.0 by
[@&#8203;timhillgit](https://togithub.com/timhillgit) in
[https://github.com/dandavison/delta/pull/1672](https://togithub.com/dandavison/delta/pull/1672)
- Disable light mode detection in tests by
[@&#8203;bash](https://togithub.com/bash) in
[https://github.com/dandavison/delta/pull/1765](https://togithub.com/dandavison/delta/pull/1765)
- Add --max-syntax-highlighting-length, set to 400 by
[@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1746](https://togithub.com/dandavison/delta/pull/1746)
- chore: cleanup brew formula file in favor of core tap by
[@&#8203;chenrui333](https://togithub.com/chenrui333) in
[https://github.com/dandavison/delta/pull/1773](https://togithub.com/dandavison/delta/pull/1773)
- wrap --help output, fix rust 1.80 build by
[@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1440](https://togithub.com/dandavison/delta/pull/1440)
- Fix delta-toggle shell script by
[@&#8203;dandavison](https://togithub.com/dandavison) in
[https://github.com/dandavison/delta/pull/1794](https://togithub.com/dandavison/delta/pull/1794)
- Do not wrap short help (-h) output by
[@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1800](https://togithub.com/dandavison/delta/pull/1800)
- Implement --diff-args by
[@&#8203;dandavison](https://togithub.com/dandavison) in
[https://github.com/dandavison/delta/pull/1697](https://togithub.com/dandavison/delta/pull/1697)
- Handle ambiguous diff header, '--- ' can also be present in a minus
hunk by [@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1787](https://togithub.com/dandavison/delta/pull/1787)
- cd: build binaries targeting GNU libc on ubuntu-20.04, not latest by
[@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1805](https://togithub.com/dandavison/delta/pull/1805)

#### New Contributors

- [@&#8203;martinml](https://togithub.com/martinml) made their first
contribution in
[https://github.com/dandavison/delta/pull/1683](https://togithub.com/dandavison/delta/pull/1683)
- [@&#8203;thorio](https://togithub.com/thorio) made their first
contribution in
[https://github.com/dandavison/delta/pull/1737](https://togithub.com/dandavison/delta/pull/1737)
- [@&#8203;madeddie](https://togithub.com/madeddie) made their first
contribution in
[https://github.com/dandavison/delta/pull/1709](https://togithub.com/dandavison/delta/pull/1709)
- [@&#8203;injust](https://togithub.com/injust) made their first
contribution in
[https://github.com/dandavison/delta/pull/1745](https://togithub.com/dandavison/delta/pull/1745)
- [@&#8203;wxpppp](https://togithub.com/wxpppp) made their first
contribution in
[https://github.com/dandavison/delta/pull/1715](https://togithub.com/dandavison/delta/pull/1715)
- [@&#8203;timhillgit](https://togithub.com/timhillgit) made their first
contribution in
[https://github.com/dandavison/delta/pull/1672](https://togithub.com/dandavison/delta/pull/1672)
- [@&#8203;chenrui333](https://togithub.com/chenrui333) made their first
contribution in
[https://github.com/dandavison/delta/pull/1773](https://togithub.com/dandavison/delta/pull/1773)

**Full Changelog**:
dandavison/delta@0.17.0...0.18.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/d-issy/dotfiles).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
izumin5210 referenced this pull request in izumin5210/dotfiles Aug 31, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [dandavison/delta](https://togithub.com/dandavison/delta) | minor |
`0.17.0` -> `0.18.0` |

---

### Release Notes

<details>
<summary>dandavison/delta (dandavison/delta)</summary>

###
[`v0.18.0`](https://togithub.com/dandavison/delta/releases/tag/0.18.0)

[Compare
Source](https://togithub.com/dandavison/delta/compare/0.17.0...0.18.0)

As usual, tons of excellent contributions, all but one not by me!
[@&#8203;th1000s](https://togithub.com/th1000s) has made a huge number
of important and difficult improvements to delta and helped with many
issues over the few years since the project started, and so I'm happy to
say that he's co-maintaining the project with me nowadays. Thanks to all
contributors for the improvements below!

#### What's Changed

- Link to Repository from Manual by
[@&#8203;bash](https://togithub.com/bash) in
[https://github.com/dandavison/delta/pull/1657](https://togithub.com/dandavison/delta/pull/1657)
- Stop highlighting unchanged whitespace by
[@&#8203;phillipwood](https://togithub.com/phillipwood) in
[https://github.com/dandavison/delta/pull/1659](https://togithub.com/dandavison/delta/pull/1659)
- Add .gitattributes rules for rust files by
[@&#8203;phillipwood](https://togithub.com/phillipwood) in
[https://github.com/dandavison/delta/pull/1245](https://togithub.com/dandavison/delta/pull/1245)
- Repair --default-language, and highlight using full filename by
[@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1549](https://togithub.com/dandavison/delta/pull/1549)
- tests: prevent parallel env var access by
[@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1681](https://togithub.com/dandavison/delta/pull/1681)
- CI: fix macOS build by [@&#8203;th1000s](https://togithub.com/th1000s)
in
[https://github.com/dandavison/delta/pull/1696](https://togithub.com/dandavison/delta/pull/1696)
- Only use `nosort` in bash <4.4 by
[@&#8203;martinml](https://togithub.com/martinml) in
[https://github.com/dandavison/delta/pull/1683](https://togithub.com/dandavison/delta/pull/1683)
- Don't read git files when --no-gitconfig is given + unused variables
by [@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1728](https://togithub.com/dandavison/delta/pull/1728)
- tests: add insta for snapshot testing by
[@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1739](https://togithub.com/dandavison/delta/pull/1739)
- tests: set terminal width to 43 by
[@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1741](https://togithub.com/dandavison/delta/pull/1741)
- Fix panic when blame-palette is empty by
[@&#8203;thorio](https://togithub.com/thorio) in
[https://github.com/dandavison/delta/pull/1737](https://togithub.com/dandavison/delta/pull/1737)
- Make relative-paths work with binary files by
[@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1740](https://togithub.com/dandavison/delta/pull/1740)
- Fix github links from master to main by
[@&#8203;madeddie](https://togithub.com/madeddie) in
[https://github.com/dandavison/delta/pull/1709](https://togithub.com/dandavison/delta/pull/1709)
- Update `terminal-colorsaurus` by
[@&#8203;bash](https://togithub.com/bash) in
[https://github.com/dandavison/delta/pull/1699](https://togithub.com/dandavison/delta/pull/1699)
- Make less version >= 633 behave like previous versions wrt. Nerd Fonts
by [@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1762](https://togithub.com/dandavison/delta/pull/1762)
- Update `catppuccin-latte` casing in `LIGHT_SYNTAX_THEMES` list by
[@&#8203;injust](https://togithub.com/injust) in
[https://github.com/dandavison/delta/pull/1745](https://togithub.com/dandavison/delta/pull/1745)
- deps: bump libc from 0.2.153 to 0.2.155 by
[@&#8203;wxpppp](https://togithub.com/wxpppp) in
[https://github.com/dandavison/delta/pull/1715](https://togithub.com/dandavison/delta/pull/1715)
- Add missing `--file-*-label` option to `--navigate` docs by
[@&#8203;injust](https://togithub.com/injust) in
[https://github.com/dandavison/delta/pull/1744](https://togithub.com/dandavison/delta/pull/1744)
- Fix copy-paste typo by [@&#8203;injust](https://togithub.com/injust)
in
[https://github.com/dandavison/delta/pull/1767](https://togithub.com/dandavison/delta/pull/1767)
- Update syntect to 5.2.0 by
[@&#8203;timhillgit](https://togithub.com/timhillgit) in
[https://github.com/dandavison/delta/pull/1672](https://togithub.com/dandavison/delta/pull/1672)
- Disable light mode detection in tests by
[@&#8203;bash](https://togithub.com/bash) in
[https://github.com/dandavison/delta/pull/1765](https://togithub.com/dandavison/delta/pull/1765)
- Add --max-syntax-highlighting-length, set to 400 by
[@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1746](https://togithub.com/dandavison/delta/pull/1746)
- chore: cleanup brew formula file in favor of core tap by
[@&#8203;chenrui333](https://togithub.com/chenrui333) in
[https://github.com/dandavison/delta/pull/1773](https://togithub.com/dandavison/delta/pull/1773)
- wrap --help output, fix rust 1.80 build by
[@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1440](https://togithub.com/dandavison/delta/pull/1440)
- Fix delta-toggle shell script by
[@&#8203;dandavison](https://togithub.com/dandavison) in
[https://github.com/dandavison/delta/pull/1794](https://togithub.com/dandavison/delta/pull/1794)
- Do not wrap short help (-h) output by
[@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1800](https://togithub.com/dandavison/delta/pull/1800)
- Implement --diff-args by
[@&#8203;dandavison](https://togithub.com/dandavison) in
[https://github.com/dandavison/delta/pull/1697](https://togithub.com/dandavison/delta/pull/1697)
- Handle ambiguous diff header, '--- ' can also be present in a minus
hunk by [@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1787](https://togithub.com/dandavison/delta/pull/1787)
- cd: build binaries targeting GNU libc on ubuntu-20.04, not latest by
[@&#8203;th1000s](https://togithub.com/th1000s) in
[https://github.com/dandavison/delta/pull/1805](https://togithub.com/dandavison/delta/pull/1805)

#### New Contributors

- [@&#8203;martinml](https://togithub.com/martinml) made their first
contribution in
[https://github.com/dandavison/delta/pull/1683](https://togithub.com/dandavison/delta/pull/1683)
- [@&#8203;thorio](https://togithub.com/thorio) made their first
contribution in
[https://github.com/dandavison/delta/pull/1737](https://togithub.com/dandavison/delta/pull/1737)
- [@&#8203;madeddie](https://togithub.com/madeddie) made their first
contribution in
[https://github.com/dandavison/delta/pull/1709](https://togithub.com/dandavison/delta/pull/1709)
- [@&#8203;injust](https://togithub.com/injust) made their first
contribution in
[https://github.com/dandavison/delta/pull/1745](https://togithub.com/dandavison/delta/pull/1745)
- [@&#8203;wxpppp](https://togithub.com/wxpppp) made their first
contribution in
[https://github.com/dandavison/delta/pull/1715](https://togithub.com/dandavison/delta/pull/1715)
- [@&#8203;timhillgit](https://togithub.com/timhillgit) made their first
contribution in
[https://github.com/dandavison/delta/pull/1672](https://togithub.com/dandavison/delta/pull/1672)
- [@&#8203;chenrui333](https://togithub.com/chenrui333) made their first
contribution in
[https://github.com/dandavison/delta/pull/1773](https://togithub.com/dandavison/delta/pull/1773)

**Full Changelog**:
dandavison/delta@0.17.0...0.18.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/izumin5210/dotfiles).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: izumin5210-update-aqua-checksum[bot] <169593670+izumin5210-update-aqua-checksum[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants