Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove some clippy warnings #383

Merged
merged 2 commits into from
Nov 7, 2020
Merged

remove some clippy warnings #383

merged 2 commits into from
Nov 7, 2020

Conversation

MarcoIeni
Copy link
Contributor

I removed all the "trivial" warnings.
14 clippy warnings remain, but they require some refactoring.

@dandavison dandavison mentioned this pull request Nov 7, 2020
Closed
@dandavison dandavison merged commit b149425 into dandavison:master Nov 7, 2020
@dandavison
Copy link
Owner

Thanks again @MarcoIeni!

@MarcoIeni
Copy link
Contributor Author

thank you for your fast reviews :)

@MarcoIeni
Copy link
Contributor Author

MarcoIeni commented Nov 7, 2020 •
edited
Loading

As I said, the remaining clippy warnings involve some refactoring, so maybe they should be solved by someone with more knowledge about the project. I don't plan to fix also those warnings at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandavison dandavison dandavison left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoIeni @dandavison