Honor GIT_CONFIG_PARAMETERS env var #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
force-pushed
the
493-GIT_CONFIG_PARAMETERS
branch
from
3dad510 to
93cedd2
Compare
|
This allows us to do things like Thanks @wyuenho for pointing out that this should be made possible; I think this now becomes the preferred method for changing delta config on-the-fly. I'll need to remember to update the README at the next release. |
When git is invoked as `git -c aaa.bbb=ccc -c ddd.eee=fff` then git sets the env var GIT_CONFIG_PARAMETERS containing the changed config entries, so that child processes can honor them. libgit2 doesn't yet honor the env var: see libgit2/libgit2#3854. Fixes #493 Fixes #307 Ref dandavison/magit-delta#13
dandavison
force-pushed
the
493-GIT_CONFIG_PARAMETERS
branch
from
93cedd2 to
dc26797
Compare
|
Nice! Can't wait to test it out in the next release. |
dandavison
added a commit
that referenced
this pull request
Feb 5, 2021
ruohola
added a commit
to ruohola/dotfiles
that referenced
this pull request
Aug 16, 2022
The original commit (1c83331) that introduced `gyn` it correctly stated that `git -c` does not work for Delta options, but nowadays it does: dandavison/delta#495
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @wyuenho @ulwlu
When git is invoked as
git -c aaa.bbb=ccc -c ddd.eee=fffthen gitsets the env var
GIT_CONFIG_PARAMETERScontaining the changed configentries, so that child processes can honor them.
libgit2 doesn't yet honor the env var: see
libgit2/libgit2#3854.
Fixes #493
Fixes #307
Ref dandavison/magit-delta#13