Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for breaking change in django-allauth #1678

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

mvandenburgh
Copy link
Member

This should be removed once the corresponding fix upstream in django-composed-confiugration is merged.
kitware-resonant/django-composed-configuration#189

This is the cause of the CI failures in this PR #1674.

This should be removed once the corresponding fix upstream in
`django-composed-confiugration` is merged.
kitware-resonant/django-composed-configuration#189
dandiapi/settings.py Outdated Show resolved Hide resolved
Co-authored-by: Dan LaManna <danlamanna@users.noreply.github.com>
@mvandenburgh
Copy link
Member Author

There's another CI failure in the python tests that is unrelated to the one this PR fixes. I'll merge this one and look into why the other one is occurring as well.

@mvandenburgh mvandenburgh merged commit 9a15880 into master Sep 11, 2023
8 of 9 checks passed
@mvandenburgh mvandenburgh deleted the fix-allauth-error branch September 11, 2023 15:54
@dandibot
Copy link
Member

dandibot commented Oct 2, 2023

🚀 PR was released in v0.3.52 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants