-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UPLOADED state to Zarr models #1698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you (in the PR description) sketch out the intended progression through the different statuses after this change?
d8677ab
to
82d706c
Compare
82d706c
to
d7e7169
Compare
We returned dandi-cli into green state again. Do you think you @AlmightyYakob or @danlamanna can workout a needed patch for it for this API change? would be appreciated. If not -- that is ok, just let me know. |
It seems no change is needed to the CLI, since it awaits the |
🚀 PR was released in |
This is a breaking API change.
This adds an
UPLOADED
state to the Zarr models, to delineate between when a user calls "finalize", and when the zarr begins ingestion.The use of the Zarr status is now as follows:
PENDING
finalize
endpoint, placing the Zarr in anUPLOADED
state and kicking off the ingestion taskINGESTING
stateCOMPLETE
statePENDING
state@jwodder The changes regarding the CLI are as follows:
finalize
on a zarr, the returned status of the zarr will now beUPLOADED
, instead ofPENDING
ZarrArchive.INGEST_ERROR_MSG
if the zarr in question is in either theUPLOADED
orINGESTING
stateZarrArchive.INGEST_ERROR_MSG
has been changed from"Zarr archive already ingested"
to"Zarr archive is currently ingesting or has already ingested"