Upgrade dandischema dependency
#1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
added
patch
danlamanna
approved these changes
Oct 11, 2023
jjnesbitt
approved these changes
Oct 11, 2023
waxlamp
approved these changes
Oct 11, 2023
|
@yarikoptic @satra any ideas why the dandi-cli tests are failing here? It seems to be unrelated to this PR, because I re-ran them on
|
|
@yarikoptic - just a ping to see why dandi-cli is failing with this PR. |
|
seems a test started to fail in dandi-cli about a week or so ago - the same as here, so changes here do not break any other test and thus should be ok. Filed dandi/dandi-cli#1332 , will look into it, |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1702.
#1702 was fixed in
dandischemaa while back with dandi/dandi-schema#167 and a new version ofdandischemawas released, but we never bumped the version ofdandischemain dandi-archive.Note this does not solve the underlying fake doi injection issue, but it will fix DOI creation on dandiarchive.org. As part of this, I will query for all published dandisets that do not have a DOI due to this bug and re-run the DOI generation on them.