Remove unnecessary atomic decorators from tasks #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `atomic` decorator isn't actually needed on these task functions. Any parts of the tasks that need to be atomic are already marked as such inside the functions that the tasks call.
mvandenburgh
force-pushed
the
remove-unneeded-atomic
branch
from
079d2b4
to
67799cf
Compare
danlamanna
approved these changes
Oct 18, 2023
|
Looks like the (this is why the CLI tests are failing) |
danlamanna
approved these changes
Oct 18, 2023
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think the
atomicdecorator actually does anything for these task functions, but please correct me if I'm missing something @danlamanna @AlmightyYakob.Any complex operations that do need to be atomic are already wrapped in an
atomicblock inside the service layer functions that the tasks are calling.