Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up handling of missing DOI_API_PREFIX setting #1721

Closed
wants to merge 2 commits into from
Closed

Clean up handling of missing DOI_API_PREFIX setting #1721

wants to merge 2 commits into from

Commits on Oct 18, 2023

  1. Clean up handling of missing DOI_API_PREFIX 

    This setting should never be unset in a real deployment of DANDI, so
silently replacing it with a default if it's missing is not ideal.
Instead, this changes it so that things fail loudly and an error is
raised if this setting is not supplied in an env var. In dev/testing
configurations, it is hardcoded to the placeholder value.
    @mvandenburgh
    mvandenburgh committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    0dd3a33 View commit details
    Browse the repository at this point in the history

  2. Add type hints

    @mvandenburgh
    mvandenburgh committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    6262166 View commit details
    Browse the repository at this point in the history