Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide workaround to specify "correct" content_type for JSON files in "inline" mode #2031

Closed
wants to merge 1 commit into from
Closed

Provide workaround to specify "correct" content_type for JSON files in "inline" mode #2031

wants to merge 1 commit into from

Conversation

yarikoptic
Copy link
Member

Closes #2027

@yarikoptic yarikoptic mentioned this pull request Sep 20, 2024
Closed
waxlamp
waxlamp reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@waxlamp waxlamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this fixes the problem in the short term, but it causes another wider problem: this kind of thing means that we are starting not to trust the data's own self-reports of its content type. Is there something we can do to fix the problem at the root?

@waxlamp
Copy link
Member

waxlamp commented Sep 23, 2024

I know this fixes the problem in the short term, but it causes another wider problem: this kind of thing means that we are starting not to trust the data's own self-reports of its content type. Is there something we can do to fix the problem at the root?

Ok I see you already raised this issue over in #2027 (comment). Let's continue discussion there.

@waxlamp
Copy link
Member

waxlamp commented Oct 23, 2024 •
edited
Loading

This PR is no longer needed, as the JSON assets in the system have been updated with the correct encodingFormat.

@waxlamp waxlamp closed this Oct 23, 2024
@waxlamp waxlamp deleted the bf-contentType branch October 23, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waxlamp waxlamp waxlamp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Open in browser" on dataset_description.json results in Download request
2 participants
@yarikoptic @waxlamp