Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use buggy version of responses #1342

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Don't use buggy version of responses #1342

merged 1 commit into from
Nov 8, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Nov 8, 2023

The tests have been failing for the past four days due to an issue with the latest version of responses. This PR excludes the version in question from use.

@jwodder jwodder added the tests Add or improve existing tests label Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c567c8b) 89.04% compared to head (f8823ee) 89.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1342   +/-   ##
=======================================
  Coverage   89.04%   89.04%           
=======================================
  Files          76       76           
  Lines       10243    10243           
=======================================
  Hits         9121     9121           
  Misses       1122     1122           
Flag Coverage Δ
unittests 89.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder
Copy link
Member Author

jwodder commented Nov 8, 2023

@yarikoptic Please merge this soon.

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Nov 8, 2023
@yarikoptic
Copy link
Member

cool, thanks! also marked for release so downstream testing of dandi-archive works as it does

      - name: Install released dandi
        if: matrix.dandi-version == 'release'
        run: pip install "dandi[test]"

@yarikoptic yarikoptic merged commit 9335182 into master Nov 8, 2023
25 checks passed
@yarikoptic yarikoptic deleted the fix-tests branch November 8, 2023 13:48
Copy link

github-actions bot commented Nov 8, 2023

🚀 PR was released in 0.58.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Create a release when this pr is merged released tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants