Add missing command to dandi-archive docker compose fixture
#1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandi-archive requires this command to be run as part of system initialization in order to initialize the database to serve as a Django cache backend. it must be run in order for any endpoint with caching enabled to work properly.
jwodder
approved these changes
Mar 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1421 +/- ##
==========================================
+ Coverage 67.96% 68.09% +0.13%
==========================================
Files 77 77
Lines 10522 10523 +1
==========================================
+ Hits 7151 7166 +15
+ Misses 3371 3357 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks for the PR! Failures seems due to ontobee being still down! Let's hope we didn't miss any side effect. Marking for release so any downstream testing benefits |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dandi-archive requires this command to be run as part of system initialization in order to initialize the database to serve as a Django cache backend. It must be run in order for any endpoint with caching enabled to work properly. See the set up instructions for docker-compose: https://github.com/dandi/dandi-archive/blob/master/DEVELOPMENT.md#initial-setup
Up until this point, the only endpoint with caching enabled was
/api/stats/, and presumably the CLI has no need to hit that in testing so this went unnoticed. However, the rate limiting introduced in dandi/dandi-archive#1899 also makes use of the database cache backend, and thus the CLI tests are failing on that PR.