Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPT+RF of zarr downloads: do not wait for full files listing + compute %done from total zarr size #1443

Merged
merged 4 commits into from
May 30, 2024

Code review: minor typing etc recommendations

08a4050
Select commit
Loading
Failed to load commit list.
Merged

OPT+RF of zarr downloads: do not wait for full files listing + compute %done from total zarr size #1443

Code review: minor typing etc recommendations
08a4050
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 20, 2024 in 1s

88.63% (+0.01%) compared to 722f1b6

View this Pull Request on Codecov

88.63% (+0.01%) compared to 722f1b6

Details

Codecov Report

Attention: Patch coverage is 96.15385% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.63%. Comparing base (722f1b6) to head (08a4050).

Files Patch % Lines
dandi/download.py 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1443      +/-   ##
==========================================
+ Coverage   88.61%   88.63%   +0.01%     
==========================================
  Files          77       77              
  Lines       10563    10572       +9     
==========================================
+ Hits         9360     9370      +10     
+ Misses       1203     1202       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.