Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: use correct variable in exception upon unknown how to handle value of "species" #1482

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

yarikoptic
Copy link
Member

Closes #1481

bug likely introduced during refactoring in a62fe7d

Closes #1481
@yarikoptic yarikoptic added the bug Something isn't working label Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.62%. Comparing base (5faa18a) to head (a303122).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1482      +/-   ##
==========================================
+ Coverage   88.52%   88.62%   +0.09%     
==========================================
  Files          77       77              
  Lines       10561    10565       +4     
==========================================
+ Hits         9349     9363      +14     
+ Misses       1212     1202      -10     
Flag Coverage Δ
unittests 88.62% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dandi/tests/test_metadata.py Outdated Show resolved Hide resolved
@jwodder jwodder added patch Increment the patch version when merged and removed bug Something isn't working labels Aug 12, 2024
Co-authored-by: John T. Wodder II <jwodder@users.noreply.github.com>
@yarikoptic yarikoptic merged commit 37b6350 into master Aug 13, 2024
27 of 28 checks passed
@yarikoptic yarikoptic deleted the bf-1481 branch August 13, 2024 14:57
Copy link

github-actions bot commented Sep 9, 2024

🚀 PR was released in 0.63.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to extract metadata: UnboundLocalError: local variable 'value' referenced before assignment
2 participants