Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: organize - show files with conflicts requiring adding _obj- #1490

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

ENH: organize - show files with conflicts requiring adding _obj- #1490

wants to merge 3 commits into from

Commits on Aug 20, 2024

  1. ENH: organize - show files with conflicts requiring adding _obj- 

    Logging check is currently not really functioning since IIRC we
do enable logging into a file at higher level than INFO. So we
might need to tune decision making here
    @yarikoptic
    yarikoptic committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    c45ffe2 View commit details
    Browse the repository at this point in the history

  2. Small tune ups from code review 

    Co-authored-by: John T. Wodder II <jwodder@users.noreply.github.com>
    @yarikoptic @jwodder
    yarikoptic and jwodder authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    c47269b View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. RF: make logging messages independent of active level - 1: hits alway… 

    …s at DEBUG

With this change logging looks like

    2024-08-21 09:42:39,718 [    INFO] 2 out of 5 paths are not unique.
     2 paths 'compete' for the path 'sub-P53CS/sub-P53CS_ses-20171101_ecephys+image.nwb':
      /home/yoh/proj/dandi/dandisets/000004/sub-P53CS/sub-P53CS_ses-20171101_obj-108aqix_ecephys+image.nwb
      /home/yoh/proj/dandi/dandisets/000004/sub-P53CS/sub-P53CS_ses-20171101_obj-lj04dr_ecephys+image.nwb
     1 more case(s) are listed at DEBUG level.
    2024-08-21 09:42:39,718 [   DEBUG] Additional non-unique paths:
     3 paths 'compete' for the path 'sub-P54CS/sub-P54CS_ses-20180101_ecephys+image.nwb':
      /home/yoh/proj/dandi/dandisets/000004/sub-P54CS/sub-P54CS_ses-20180101_obj-1ru98u8_ecephys+image.nwb
      /home/yoh/proj/dandi/dandisets/000004/sub-P54CS/sub-P54CS_ses-20180101_obj-1ukzk61_ecephys+image.nwb
      /home/yoh/proj/dandi/dandisets/000004/sub-P54CS/sub-P54CS_ses-20180101_obj-1vx1a5w_ecephys+image.nwb
    2024-08-21 09:42:39,718 [    INFO] We will try adding _obj- based on crc32 of object_id
    @yarikoptic
    yarikoptic committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    e456ebb View commit details
    Browse the repository at this point in the history