Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.8 support (remove typing_extensions from depends) #262

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

yarikoptic
Copy link
Member

No description provided.

@yarikoptic yarikoptic changed the title Drop 3.8 support (remove typing_extensions from depends) Drop Python 3.8 support (remove typing_extensions from depends) Nov 4, 2024
@yarikoptic yarikoptic added the minor Increment the minor version when merged label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.58%. Comparing base (7074582) to head (eaa32d2).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
- Coverage   97.58%   97.58%   -0.01%     
==========================================
  Files          16       16              
  Lines        1741     1739       -2     
==========================================
- Hits         1699     1697       -2     
  Misses         42       42              
Flag Coverage Δ
unittests 97.58% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

before we went for -12 since needed 3.8. Let's see if would work for 3.9
@yarikoptic
Copy link
Member Author

whatever had to run seems to have ran and is green! there is some odd memory of 3.8 and macos-12 which are no more:

❯ git grep -e macos-12 -e '3\.8' | grep -v CHANG
❯ 

Let's proceed so other PRs could get greener too

@yarikoptic yarikoptic merged commit 121d40f into master Nov 4, 2024
64 checks passed
@yarikoptic yarikoptic deleted the rf-3.9 branch November 4, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants