Supply empty haste modulemap for jest runtime resolver #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
damn, the solution was to remove a bunch of code? 🍡 Thanks a lot for digging in here @kwonoj - I can't imagine this was a quick one to understand, thanks so much! |
This was referenced Jun 9, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates bootstrap logic for jest runtime, instead of acquiring haste module map by building whole just supply empty modulemap directly. This approach works by danger config doesn't provide
config.roots, so there's no hastemap's actually generated anyway.For original reason why it wasn't work in windows platform, refer jestjs/jest#3776 - if those PR's accepted and if you prefer to preserve existing logic, bump up jest would resolve issue as well.