Separate Danger Run into two processes #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…than our internal one
3 tasks
|
OK, this is now green in terms of the biggest refactorings 👍 |
orta
force-pushed
the
convert_danger_to_danger_process
branch
3 times, most recently
from
f7830b0
to
71da128
Compare
|
CI now runs every example dangerfile through
|
orta
force-pushed
the
convert_danger_to_danger_process
branch
4 times, most recently
from
697c00c
to
63d25df
Compare
|
Only the conversion of |
orta
force-pushed
the
convert_danger_to_danger_process
branch
from
63d25df
to
e735469
Compare
Generated by 🚫 dangerJS |
orta
force-pushed
the
convert_danger_to_danger_process
branch
5 times, most recently
from
d9ee88e
to
66db387
Compare
orta
force-pushed
the
convert_danger_to_danger_process
branch
3 times, most recently
from
bbc2635
to
b64e54a
Compare
orta
force-pushed
the
convert_danger_to_danger_process
branch
from
b64e54a
to
3634e93
Compare
…nd to the host process - fixes #400
orta
changed the title
This was referenced Oct 22, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the JavaScript runner to also work in the same method as
danger process. The idea is that we can use process separation even inside the JavaScript client built into Danger JS. ( see the docs if this is new to you ) which means new features to DangerJS will definitely improve anyone using Danger in their own language.This process separation will work with danger/peril#159 to solidify the idea of separation for Peril and the runner (on lambda.)
TODO:
dangerto actually bedanger process "danger runner"basicallygit.utils,github.utils,github.api