Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow returning a value and having Danger execute the code #574

Merged
merged 2 commits into from
Apr 25, 2018

Conversation

orta
Copy link
Member

@orta orta commented Apr 25, 2018

Re: danger/peril#240

I don't think this is really something people will need at the danger-js level of abstraction, but I think it makes a lot of sense for Peril when working with tests, events or PRs in general

@orta
Copy link
Member Author

orta commented Apr 25, 2018

wonder if this is a node 10 issue

@orta
Copy link
Member Author

orta commented Apr 25, 2018

@orta orta merged commit a575123 into master Apr 25, 2018
@orta orta deleted the return_values branch April 25, 2018 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant