Adapt emoji for Bitbucket server to fix "Database error has occurred" #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acecilia
commented
Aug 1, 2018
| const fullDiff = danger.git.diffForFile('foo.js') | ||
| const addedLines = danger.git.diffForFile('foo.js', ['add']) | ||
| const removedLines = danger.git.diffForFile('foo.js', ['del']) | ||
| const fullDiff = danger.git.diffForFile("foo.js") |
There was a problem hiding this comment.
I did not add this changes, I think the hooks that the project has are causing this.
orta
approved these changes
Aug 1, 2018
| const fullDiff = danger.git.diffForFile('foo.js') | ||
| const addedLines = danger.git.diffForFile('foo.js', ['add']) | ||
| const removedLines = danger.git.diffForFile('foo.js', ['del']) | ||
| const fullDiff = danger.git.diffForFile("foo.js") |
| ${results.messages.map(printViolation("📖")).join("\n")} | ||
| ${results.fails.map(printViolation(noEntryEmoji)).join("\n")} | ||
| ${results.warnings.map(printViolation(warningEmoji)).join("\n")} | ||
| ${results.messages.map(printViolation(messageEmoji)).join("\n")} |
| @@ -13,6 +13,11 @@ | |||
|
|
|||
| ## Master | |||
|
|
|||
| # 3.8.3 | |||
There was a problem hiding this comment.
Adding this means likely merge conflicts, best to leave them next time - I normally add this version when I create the new release. I should make a danger rule for that 👍
There was a problem hiding this comment.
I can avoid adding changelog for the next PR. Do you prefer that? Or just add the changelog without specifying the version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitbucket server only supports emojis in recent versions. For example, Bitbucket v4.10.1 does not support them, and when commenting with them the server returns an error saying "Database error has occurred".
Implementation similar to danger/danger@638943d#diff-4b908d596ce5ef33cce2a524a5694a4f