Skip to content

Commit

Permalink
chore: Remove TODO fixed in vega#3480
Browse files Browse the repository at this point in the history
  • Loading branch information
dangotbanned committed Jul 29, 2024
1 parent 00985dc commit 831d653
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions altair/vegalite/v5/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -4000,7 +4000,6 @@ def __init__(
columns: Optional[float] = Undefined,
**kwargs,
) -> None:
# TODO: move common data to top level?
for spec in concat:
_check_if_valid_subspec(spec, "ConcatChart")
super().__init__(data=data, concat=list(concat), columns=columns, **kwargs) # type: ignore[arg-type]
Expand Down Expand Up @@ -4105,7 +4104,6 @@ def __init__(
hconcat: Sequence[ConcatType] = (),
**kwargs,
) -> None:
# TODO: move common data to top level?
for spec in hconcat:
_check_if_valid_subspec(spec, "HConcatChart")
super().__init__(data=data, hconcat=list(hconcat), **kwargs) # type: ignore[arg-type]
Expand Down Expand Up @@ -4210,7 +4208,6 @@ def __init__(
vconcat: Sequence[ConcatType] = (),
**kwargs,
) -> None:
# TODO: move common data to top level?
for spec in vconcat:
_check_if_valid_subspec(spec, "VConcatChart")
super().__init__(data=data, vconcat=list(vconcat), **kwargs) # type: ignore[arg-type]
Expand Down Expand Up @@ -4317,7 +4314,6 @@ def __init__(
layer: Sequence[LayerType] = (),
**kwargs,
) -> None:
# TODO: move common data to top level?
# TODO: check for conflicting interaction
for spec in layer:
_check_if_valid_subspec(spec, "LayerChart")
Expand Down

0 comments on commit 831d653

Please sign in to comment.