improve 404 page and rename web vault pageTitle #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is going to be too much for the patch file in my opinion. I have thought about this already, i think it is better that we create a static page baked in into Vaultwarden or via a handlebars file and use that for the 404. That way we can also make it work correctly for sub path. |
|
Looks like you seem to also changed the title. I looked for that, but didn't seem to be able to find it. Looks like i was searching for the wrong function hehe. |
|
I'll make a new PR for changing only the page title. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the 404 page currently still has the Bitwarden logo, I've created a new one:
And I was wondering, if we should call it Vaultwarden Web Vault now too?