Skip to content

Commit

Permalink
Merge pull request #2491 from BlackDex/issue-2490
Browse files Browse the repository at this point in the history
Fix armv6 issue with bullseye images
  • Loading branch information
dani-garcia authored May 24, 2022
2 parents d0a7437 + 21b433c commit bf0b8d9
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 6 deletions.
14 changes: 8 additions & 6 deletions docker/Dockerfile.j2
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,6 @@ ENV DEBIAN_FRONTEND=noninteractive \
CARGO_HOME="/root/.cargo" \
USER="root"

{# {% if "alpine" not in target_file and "buildx" in target_file %}
# Debian based Buildx builds can use some special apt caching to speedup building.
# By default Debian based images have some rules to keep docker builds clean, we need to remove this.
# See: https://hub.docker.com/r/docker/dockerfile
RUN rm -f /etc/apt/apt.conf.d/docker-clean; echo 'Binary::apt::APT::Keep-Downloaded-Packages "true";' > /etc/apt/apt.conf.d/keep-cache
{% endif %} #}

# Create CARGO_HOME folder and don't download rust docs
RUN {{ mount_rust_cache -}} mkdir -pv "${CARGO_HOME}" \
Expand Down Expand Up @@ -227,6 +221,14 @@ RUN mkdir /data \
&& rm -rf /var/lib/apt/lists/*
{% endif %}

{% if "armv6" in target_file and "alpine" not in target_file %}
# In the Balena Bullseye images for armv6/rpi-debian there is a missing symlink.
# This symlink was there in the buster images, and for some reason this is needed.
# hadolint ignore=DL3059
RUN ln -v -s /lib/ld-linux-armhf.so.3 /lib/ld-linux.so.3

{% endif -%}

{% if "amd64" not in target_file %}
# hadolint ignore=DL3059
RUN [ "cross-build-end" ]
Expand Down
5 changes: 5 additions & 0 deletions docker/armv6/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,11 @@ RUN mkdir /data \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*

# In the Balena Bullseye images for armv6/rpi-debian there is a missing symlink.
# This symlink was there in the buster images, and for some reason this is needed.
# hadolint ignore=DL3059
RUN ln -v -s /lib/ld-linux-armhf.so.3 /lib/ld-linux.so.3

# hadolint ignore=DL3059
RUN [ "cross-build-end" ]

Expand Down
5 changes: 5 additions & 0 deletions docker/armv6/Dockerfile.buildx
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,11 @@ RUN mkdir /data \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*

# In the Balena Bullseye images for armv6/rpi-debian there is a missing symlink.
# This symlink was there in the buster images, and for some reason this is needed.
# hadolint ignore=DL3059
RUN ln -v -s /lib/ld-linux-armhf.so.3 /lib/ld-linux.so.3

# hadolint ignore=DL3059
RUN [ "cross-build-end" ]

Expand Down

0 comments on commit bf0b8d9

Please sign in to comment.