-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to download attachment after uploading via mobile client (Android/iOS) #2644
Comments
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
@Tieneks Hmm that is strange. |
This PR attends to mitigate (not fix) dani-garcia#2644. There seems to be an issue when uploading files either as attachment or via send via the mobile (Android) client. The binary data gets transfered correctly to Vaultwarden (Checked via Wireshark), but the data is not parsed correctly for some reason. Since the parsing is not done by Vaultwarden it self, i think we should at least try to prevent saving the data and letting users think all fine. Further investigation is needed to actually fix this issue. This is just a quick patch.
@Tieneks well, i have it patched, but not fixed. We are looking into a better way to actually fix this. |
This PR attends to mitigate (not fix) dani-garcia#2644. There seems to be an issue when uploading files either as attachment or via send via the mobile (Android) client. The binary data gets transfered correctly to Vaultwarden (Checked via Wireshark), but the data is not parsed correctly for some reason. Since the parsing is not done by Vaultwarden it self, i think we should at least try to prevent saving the data and letting users think all fine. Further investigation is needed to actually fix this issue. This is just a quick patch.
It also happens with the chrome extension and even files saved months before are getting downloaded as 8 byte files. Edit: Same with the safari extension |
@hendrik1120 works fine for me. I suggest to check the reverse proxy settings and logs. |
I tested it and am getting an error message, as expected. Now at least the file won't "disappear". tl;dr: |
This is a small patch to be able to let Vaultwarden handle files/attachments uploaded by the Bitwarden Mobile clients. For more details see: Issue @ Vaultwarden: dani-garcia/vaultwarden#2644 Issue @ Rocket: rwf2/Rocket#2299 Issue @ Bitwarden: bitwarden/mobile#2018
This is a small patch to be able to let Vaultwarden handle files/attachments uploaded by the Bitwarden Mobile clients. For more details see: Issue @ Vaultwarden: dani-garcia/vaultwarden#2644 Issue @ Rocket: rwf2/Rocket#2299 Issue @ Bitwarden: bitwarden/mobile#2018 I hope this specific issue will be fixed upstream by Bitwarden, or that Rocket will provide a way handle these kind of invalid requests. Until then we need to use this patch and keep it in-sync with upstream multer-rs.
This patch fixes the file upload send by the mobile clients. It resolves dani-garcia#2644 by always providing a `Content-Type` even though one isn't set in this specific case. I do hope it will be fixed upstream by either Bitwarden by fixing the client. Or Rocket by allowing to override this somehow. Until then, we can use this patched version of multer-rs. Issue @ Rocket: rwf2/Rocket#2299 Issue @ Bitwarden: bitwarden/mobile#2018 Also updated some dependencies.
This is a small patch to be able to let Vaultwarden handle files/attachments uploaded by the Bitwarden Mobile clients. For more details see: Issue @ Vaultwarden: dani-garcia/vaultwarden#2644 Issue @ Rocket: rwf2/Rocket#2299 Issue @ Bitwarden: bitwarden/mobile#2018 I hope this specific issue will be fixed upstream by Bitwarden, or that Rocket will provide a way handle these kind of invalid requests. Until then we need to use this patch and keep it in-sync with upstream multer-rs.
This is a small patch to be able to let Vaultwarden handle files/attachments uploaded by the Bitwarden Mobile clients. For more details see: Issue @ Vaultwarden: dani-garcia/vaultwarden#2644 Issue @ Rocket: rwf2/Rocket#2299 Issue @ Bitwarden: bitwarden/mobile#2018 I hope this specific issue will be fixed upstream by Bitwarden, or that Rocket will provide a way handle these kind of invalid requests. Until then we need to use this patch and keep it in-sync with upstream multer-rs.
Subject of the issue
Unable to download attachment after uploading via Android app. Downloading after uploading via web vault causes no issues.
Deployment environment
v1.25.1
Install method:
Docker image on Synology NAS
Clients used:
Web vault, Android app
Reverse proxy and version:
MySQL/MariaDB or PostgreSQL version:
SQLite
Other relevant details:
Steps to reproduce
Popup shows correct name and size of attachment.
The attached file does show up on the server in data/attachments/[FOLDER] with an expected size.
Expected behaviour
Uploading an attachment via the Android app should allow you to download the attachment later from any client.
Actual behaviour
The attachment is "gone" after uploading it via the Android app, cannot be downloaded and can only be removed.
Troubleshooting data
Your environment (Generated via diagnostics page)
Config (Generated via diagnostics page)
Show Running Config
Environment settings which are overridden:
The text was updated successfully, but these errors were encountered: