Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing register endpoint in identity API for upcoming Bitwarden November release #2889

Closed
prettyv opened this issue Nov 4, 2022 · 3 comments · Fixed by #2920
Closed

Missing register endpoint in identity API for upcoming Bitwarden November release #2889

prettyv opened this issue Nov 4, 2022 · 3 comments · Fixed by #2920
Assignees
Labels
future Vault Issue specific to Vault that wasn't released yet

Comments

@prettyv
Copy link

prettyv commented Nov 4, 2022

Bitwarden has a deprecation notice for the November releases planned for 2022-11-16, upping the Bitwarden server version requirement to >=1.46.0. Concretely this concerns the two endpoints /identity/accounts/prelogin and /identity/accounts/register, which were originally moved from /api and deprecated in this commit.

The prelogin endpoint has already been implemented in the identity module I see, but register seems to still be missing, which I assume will lead to issues later in the month for new registrations.

@BlackDex
Copy link
Collaborator

BlackDex commented Nov 4, 2022

Since the register endpoint can only be accessed via the web-vault, and we try to match the ones we support, the impact will be almost none. Before we will match and update we do need to fix that though.

There are some other fixes we need to do also for export on orgs, which I'm working on atm.

@BlackDex BlackDex added future Vault Issue specific to Vault that wasn't released yet low priority Won't fix anytime soon, but will accept PR if provided labels Nov 4, 2022
@prettyv
Copy link
Author

prettyv commented Nov 5, 2022

Since the Bitwarden desktop client has an interface for creating an account I assumed that this would use the register endpoint as well. Although the UI doesn't communicate clearly if this would create an account via the configured self-hosted server URL or only on official Bitwarden servers (the settings button disappears on the create account page, so that might be an indication towards that). I didn't actively create an account via the client myself yet, so I'm not sure, you may be right.

@GeekCornerGH
Copy link
Contributor

GeekCornerGH commented Nov 12, 2022

@BlackDex @prettyv So I tried today, with my 2022.10.1 client. It actually tries to register on the selfhosted instance as long you specified your instance url in the login page, probably higher than low priority then.

@BlackDex BlackDex self-assigned this Nov 14, 2022
BlackDex added a commit to BlackDex/vaultwarden that referenced this issue Nov 14, 2022
In the upcomming web-vault and other clients they changed the register
endpoint from `/api/accounts/register` to `/identity/register`.

This PR adds the new endpoint to already be compatible with the new
clients.

Fixes dani-garcia#2889
@BlackDex BlackDex removed the low priority Won't fix anytime soon, but will accept PR if provided label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future Vault Issue specific to Vault that wasn't released yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants