Upgrade Feature-Policy to Permissions-Policy #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlackDex
approved these changes
Jan 11, 2022
jjlin
suggested changes
Jan 11, 2022
src/util.rs
Outdated
| @@ -27,7 +27,7 @@ impl Fairing for AppHeaders { | |||
| } | |||
|
|
|||
| fn on_response(&self, _req: &Request, res: &mut Response) { | |||
| res.set_raw_header("Feature-Policy", "accelerometer 'none'; ambient-light-sensor 'none'; autoplay 'none'; camera 'none'; encrypted-media 'none'; fullscreen 'none'; geolocation 'none'; gyroscope 'none'; magnetometer 'none'; microphone 'none'; midi 'none'; payment 'none'; picture-in-picture 'none'; sync-xhr 'self' https://haveibeenpwned.com https://2fa.directory; usb 'none'; vr 'none'"); | |||
| res.set_raw_header("Permissions-Policy", "accelerometer=(); ambient-light-sensor=(); autoplay=(); camera=(); encrypted-media=(); fullscreen=(); geolocation=(); gyroscope=(); magnetometer=(); microphone=(); midi=(); payment=(); picture-in-picture=(); sync-xhr=(self \"https://haveibeenpwned.com\" \"https://2fa.directory\"); usb=(); vr=()"); | |||
There was a problem hiding this comment.
Permissions-Policy uses commas as separators, not semicolons.
There was a problem hiding this comment.
That is what I get for copy + paste. I have changed the semicolons to commas.
There was a problem hiding this comment.
Could you squash the commits? Or do a force push?
The following should work (but this isn't tested)
git reset --soft HEAD~1
git commit --amend --no-edit
git push origin +iamdoubz-feature-to-permissions-policy-patchThere was a problem hiding this comment.
That was really fun... there is only one commit now. (PS The three commands did work)
williamdes
approved these changes
Jan 12, 2022
Convert old, soon to be defunct, Feature-Policy with its replacement Permissions-Policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert old, soon to be defunct, Feature-Policy with its replacement Permissions-Policy