Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable legacy X-XSS-Protection feature #2380

Merged
merged 1 commit into from
Mar 26, 2022

Conversation

Wonderfall
Copy link
Contributor

Obsolete in modern browsers, unsafe, and largely replaced by CSP.

Since there are still a few browsers using it, we should explicitly disable it for now to be on the safe side.

Copy link
Contributor

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably add a comment line above for other devs to understand the 0

Obsolete in every modern browser, unsafe, and replaced by CSP
@Wonderfall
Copy link
Contributor Author

Done! :)

Copy link
Contributor

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dani-garcia dani-garcia merged commit 81f0c2b into dani-garcia:main Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants