Database connection init #2440
Merged
Database connection init #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is probably mainly useful for running connection-scoped pragma statements.
`PRAGMA busy_timeout = 5000` tells SQLite to keep trying for up to 5000 ms when there is lock contention, rather than aborting immediately. This should hopefully prevent the vast majority of "database is locked" panics observed since the async transition. `PRAGMA synchronous = NORMAL` trades better performance for a small potential loss in durability (the default is `FULL`). The SQLite docs recommend `NORMAL` as "a good choice for most applications running in WAL mode".
BlackDex
requested changes
Apr 27, 2022
The main pro is less config options, while the main con is less clarity in what the defaults are for the various database types.
BlackDex
approved these changes
Apr 29, 2022
|
With this merged we can probably consider removing some of the uses of crate::util::retry() which I think was added to solve this "Database locked" issue as well. |
|
That depends. If this was only for sqlite, the probably yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for database connection init statements. This is probably mainly useful for running connection-scoped pragma statements.
Also adds default connection-scoped pragmas for SQLite:
PRAGMA busy_timeout = 5000tells SQLite to keep trying for up to 5000 ms when there is lock contention, rather than aborting immediately. This should hopefully prevent the vast majority of "database is locked" panics observed since the async transition, e.g.: Every one to three hours at xx:05 'rocket-worker-thread' panicked at 'Error loading xxxx: DatabaseError(__Unknown, "database is locked")' #2436PRAGMA synchronous = NORMALtrades better performance for a small potential loss in durability (the default isFULL). The SQLite docs recommendNORMALas "a good choice for most applications running in WAL mode".