Fix upload limits and disable color logs #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The limits for uploading files were to small in regards to the allowed maximum filesize of the Bitwarden clients including the web-vault. Changed both `data-form` (used for Send) and `file` (used for attachments) to be 525MB, this is the same size we already check our selfs. Also changed the `json` limit to be 20MB, this should allow very large imports with 4000/5000+ items depending on if there are large notes or not. And, also disabled Rocket from outputting colors, these colors were also send to the log files and syslog. I think this changed in Rocket 0.5rc somewhere, need to look a bit further into that maybe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The limits for uploading files were to small in regards to the allowed
maximum filesize of the Bitwarden clients including the web-vault.
Changed both
data-form(used for Send) andfile(used forattachments) to be 525MB, this is the same size we already check our selfs.
Also changed the
jsonlimit to be 20MB, this should allow very largeimports with 4000/5000+ items depending on if there are large notes or not.
And, also disabled Rocket from outputting colors, these colors were also
send to the log files and syslog. I think this changed in Rocket 0.5rc
somewhere, need to look a bit further into that maybe.