Adding "UserEnabled" and "CreatedAt" member to the json output of a User

[Lowaiz]

Adding "UserEnabled" and "CreatedAt" member to the json output of a User in the admin/users and admin/users/<ID> web routes.

[BlackDex]

I'd rather not add those items there, since these are also used to return the user object to the Bitwarden clients.
It is better to add them to the generated json output within admin.rs instead.

Same goes for #2524, and in that case, i would probably suggest to merge them into one PR instead of two different ones.

[Lowaiz]

I applied the changes. But I have one question, do we name those json members as in the users_overview functions of admin.rs or with Camel Case syntax as in the to_json method of the User class ?

[BlackDex]

Since the rest of the json is CamelCase i think it is best to keep that the same in this case.

[Lowaiz]

Here is the Camel Case !

[BlackDex]

Could you squash the commits into one commit? Else it will clutter the git-history a bit.
You could do that with (from the top of my head)

git reset --soft HEAD~4
git commit -a
git push origin +add_disabled_member_to_json_user

That should reset the commits to the starting point you were, and leave the changes you made.
Then you can commit that again, and do a force push so the latest commit will be the only commit here :) .

[Lowaiz]

Squash done and thank you for the commands.

[BlackDex]

The build fails because it's not formatted correctly.
I suggest to install pre-commit and use that.
See: https://pre-commit.com/

This repo already has the correct pre-commit config there, all you need to do after you installed it is run pre-commit install, then run the --reset soft again and do a commit, this will check everything which is needed for the PR to be valid (in a format/clippy sense way at least)