Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more clippy checks for better code/readability #2611

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Add more clippy checks for better code/readability #2611

merged 1 commit into from
Jul 15, 2022

Commits on Jul 10, 2022

  1. Add more clippy checks for better code/readability 

    A bit inspired by @paolobarbolini from this commit at lettre lettre/lettre#784 .
I added a few more clippy lints here, and fixed the resulted issues.

Overall i think this could help in preventing future issues, and maybe
even peformance problems. It also makes some code a bit more clear.

We could always add more if we want to, i left a few out which i think
arn't that huge of an issue. Some like the `unused_async` are nice,
which resulted in a few `async` removals.

Some others are maybe a bit more estatic, like `string_to_string`, but i
think it looks better to use `clone` in those cases instead of `to_string` while they already are a string.
    @BlackDex
    BlackDex committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    55d7c48 View commit details
    Browse the repository at this point in the history