allow the removal of non-confirmed owners #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensure user_to_edit and user_to_delete are actually confirmed users, before checking if they are the last owner of an organization.
BlackDex
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you invite a new user as another owner of an organization you cannot remove or change the role of the user until the user accepts the invitation and is confirmed. This behavior was introduced in 1722742 (previously, in 1.25.2 you could remove yourself as the owner as long as you had invited someone else as owner which would also be incorrect).
This change ensures user_to_edit and user_to_delete are actually confirmed users, before checking if they are the last owner of an organization.