Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CreationDate to cipher response JSON #2813

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Add CreationDate to cipher response JSON #2813

merged 1 commit into from
Oct 14, 2022

Conversation

jjlin
Copy link
Contributor

@jjlin jjlin commented Oct 12, 2022

Upstream PR: bitwarden/server#2142

I don't think this field is used for anything currently, but probably better to add it now than be surprised later.

@BlackDex
Copy link
Collaborator

They are adding it to the cipher edit/view screens.
It also looks like they check if it exists, if not then it's null and not used/shown.

@dani-garcia dani-garcia merged commit f49eb8e into dani-garcia:main Oct 14, 2022
@jjlin jjlin deleted the creation-date branch October 19, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackDex BlackDex BlackDex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjlin @BlackDex @dani-garcia