Fix master password hint update not working.

[BlackDex]

• The Master Password Hint input has changed it's location to the password update form. This PR updates the code to process this.

• Also changed the ProfileData struct to exclude Culture and MasterPasswordHint, since both are not used at all, and when not defined they will also not be allocated.

Fixes #2833

[tessus]

Just out of curosity, this means that people have to change their password to change the password hint, correct? If yes, it's a bit of a strange workflow. ;-)

Update: I know this is coming from bitwarden, but I am just wondering what their SW designers are thinking. Very odd design choices.

This just came to mind, because I told my dad back then not to worry about the password hint, since he could change it afterwards. Hmm, I guess not true anymore.

[BlackDex]

Well, the flow is kinda ok i think.
You probably only set the password hint when you want to change the password, because if you change the password, the hint needs to be changed to.

Also, you can still provide the old-password as the new-password and that would work just fine.

[tessus]

In most cases you are correct. I just find it strange, not being able to edit the current one. e.g. when there's a typo.

I know, this is not important at all, it's just that after almost 30 years in IT, I still sometimes wonder... haha.

[stefan0xC]

Looks good to me. But you can set your password as the hint when changing this in this form (not while signing up). Is this something we can/should prevent or something the client is missing?

[BlackDex]

Looks good to me. But you can set your password as the hint when changing this in this form (not while signing up). Is this something we can/should prevent or something the client is missing?

If there is a check right now during registering and not during change, then you need to report this upstream. We can't check if the password and hint match on the server side.

[stefan0xC]

Done: bitwarden/clients#3821